This repository was archived by the owner on Jan 16, 2021. It is now read-only.
Improve visibility of initialization order. #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlutsenko
force-pushed
the
nlutsenko.exceptions
branch
from
9b06050 to
69c8a38
Compare
nlutsenko
force-pushed
the
nlutsenko.exceptions
branch
2 times, most recently
from
d7265d1 to
b43175a
Compare
nlutsenko
force-pushed
the
nlutsenko.exceptions
branch
from
b43175a to
5cc9849
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should improve the visilbility of our initialization order requirement.
Thanks @demosten for catching the fact that we don't rethrow exceptions in the blocks.